Re: svn commit: rev 300 - trunk/subversion/include trunk/subversion/libsvn_subr trunk/subversion/tests/libsvn_subr

cmpilato@tigris.org wrote:

>Author: cmpilato
>Date: 2001-10-24 16:19 GMT
>New Revision: 300
>
>Modified:
> trunk/subversion/include/svn_path.h
> trunk/subversion/libsvn_subr/path.c
> trunk/subversion/tests/libsvn_subr/path-test.c
>Log:
>* subversion/include/svn_path.h
>* subversion/libsvn_subr/path.c
>
> (char_is_uri_safe, svn_path_is_uri_safe, svn_path_uri_encode,
> svn_path_uri_decode): New functions.
>

This produces three new warnings on Windows:

C:\Home\brane\src\svn\repo\subversion\libsvn_subr\path.c(544) : warning C4018: '<' : signed/unsigned mismatch
C:\Home\brane\src\svn\repo\subversion\libsvn_subr\path.c(563) : warning C4018: '<' : signed/unsigned mismatch
C:\Home\brane\src\svn\repo\subversion\libsvn_subr\path.c(609) : warning C4018: '<' : signed/unsigned mismatch

Again, it's because you're comparing an int with a svn_string_t::len.
This is rather a bore.

Please, let's decide once and for all what we'll do about this. Either
make svn_string_t::len an int, or use apr_size_t for induction variables
in loops that traverse a string. My vote is for the second option.

-- 
Brane �ibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org