[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: editor 'copyfrom' args

From: <kfogel_at_collab.net>
Date: 2001-10-23 17:59:50 CEST

Ben Collins-Sussman <sussman@collab.net> writes:
> Anyway, the "practical" thing to do is just pass the full URL to
> add_file and add_directory... and then let the RA layer do the
> splitting before calling svn_fs_copy(). But this bugs me, because we
> really shouldn't be sending URLs into editors. Editors have remanined
> relatively abstract up till now. I'd hate to ruin this.

Well, I see what you're talking about, but I'm not sure it's really
such a badness to be sending URLs into editors. Remember, the editor
itself isn't using the copyfrom-* arguments to affect its edit, except
to pass it along to the target of the edit (in this case, the
repository). Sure, the editor may split off the path portion if it
can or whatever, but basically, it's just passing those args through
unchanged.

Think of it like this: those args represent ancestry data. If the
ancestry were in another repository entirely, then the fs might well
choose to record the entire URL (!) as the copyfrom arg. If it's the
same repository, then it makes sense to store just the paths.

And what are these parameters used for later? For driving the reverse
editor -- an update editor. That editor won't see them, directly;
instead, its driver will use them to determine what editor commands to
issue.

So this data really is part of the fs, not the editor calls; the
editor calls are just a means of transporting it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006

This is an archived mail posted to the Subversion Dev mailing list.