Re: "svn log" behavior and implementation

<kfogel@collab.net> writes:

> $ svn log -r 20:30 foo.c

Just to be sure, what will be the output of this command?
It will show log message which foo.c was changed, right?

> Each commit's log message contains the revision number, author, date,
> and the actual log comment. Should each message also contain all the
> changed paths for that commit? (That is, all files on which text or
> props have been changed, and all dirs on which props have been changed
> or entries added or deleted.)

If that functionality is desired, I want them to be a
separate command or add an option to show changed files.
It probably depends on the way the log is written but I
normally don't want every changed files to be listed by
typing svn log.

> svn_error_t *(*get_log)
> (void *session_baton,
> apr_array_header_t *paths, /* or maybe apr_hash_t... */
> svn_revnum_t *start,
> svn_revnum_t *end,
> svn_client_log_entry_receiver_t *receiver /* see below */
> void *receiver_baton); /* see below */
>
> That callback looks something like this
>
> typedef svn_error_t *(*svn_client_log_entry_receiver_t)
> (void *baton,
> apr_array_header_t *changed_paths,
> const char *author,
> apr_time_t date,
> svn_revnum_t revision,
> const char *message);

I don't have anything against it but how about client pull
interface? It will allow clients to decide not to get some
properties or changed paths. I'm thinking about using this
in my svnmirror script to get revision properties. Then it
will be able to mirror Subversion repository with only
Subversion protocol. What I'm saying is, I don't want to
have changed_paths computed every time when I've already
decided to ignore them. :-)

The interface will be like:

 svn_error_t *(*get_rev_prop) (void *session_baton,
                               svn_string_t **value,
                               svn_string_t *name,
                               svn_revnum_t revision)

 svn_error_t *(get_changed_paths) (void *session_baton,
                                   apr_array_header_t **changed_paths,
                                   svn_revnum_t revision)

-- 
Yoshiki Hayashi
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org