Re: installing that man page

Couple of nits below.

On Fri, Oct 19, 2001 at 01:20:57PM +0200, Daniel Stenberg wrote:
>
> Index: ./Makefile.in
> ===================================================================
> --- ./.svn/text-base/Makefile.in Wed Oct 10 10:13:47 2001
> +++ ./Makefile.in Fri Oct 19 13:14:43 2001
> @@ -25,6 +25,9 @@
> bindir = @bindir@
> fs_bindir=@bindir@
> includedir = @includedir@
> +mandir = @mandir@
> +srcdir = @srcdir@
> +infodir = @infodir@
>
> ### should search for these...
> MAKEINFO = makeinfo
> @@ -72,6 +75,7 @@
> INSTALL_INCLUDE = $(INSTALL) -m 644
> INSTALL_MOD_SHARED = @APXS@ -i -a
> INSTALL_MOD_STATIC = $(INSTALL) -m 644
> +INSTALL_DATA = $(INSTALL) -m 644
>
> PYTHON = @PYTHON@
>
> @@ -233,3 +237,39 @@
>
> .dvi.pdf:
> $(DVIPDF) $< $@
> +
> +install-man: install-man1
> +
> +man1pages = subversion/clients/cmdline/man/svn.1

I would like to see a these added as a target to build.conf and gen-make.py,
so that build.conf contains all the targets we build.

> +man1dir = $mandir/man1
             ^^^^
needs to be $(mandir)

> +install-man1: $(man1pages)
> + $(MKDIR) $(DESTDIR)$(man1dir)

What is $(DESTDIR)? and should the $(mandir) generated from configure be
absolute?

> + @list='$(man1pages)'; \
> + for i in $$list; do \
> + if test -f $$srcdir/$$i; then file=$$srcdir/$$i; \
> + else file=$$i; fi; \
> + ext=`echo $$i | sed -e 's/^.*\\.//'`; \
> + inst=`echo $$i | sed -e 's/\\.[0-9a-z]*$$//'`; \
> + inst=`echo $$inst | sed -e 's/^.*\///'`; \
> + inst=`echo $$inst`.$$ext; \
> + echo "$(INSTALL_DATA) $$file $(DESTDIR)$(man1dir)/$$inst"; \
> + $(INSTALL_DATA) $$file $(DESTDIR)$(man1dir)/$$inst; \
> + done
> +
> +infopages = doc/user/manual/svn-manual.info \
> + doc/user/svn_for_cvs_users/svn_for_cvs_users.info \
> + doc/programmer/design/svn-design.info \
> + doc/programmer/design/svn-design.info-1 \
> + doc/programmer/design/svn-design.info-2 \
> + doc/programmer/design/svn-design.info-3

Same thing here about adding to build.conf instead of directly in Makefile.in

> +
> +install-info: $(infopages)
> + $(MKDIR) $(DESTDIR)$(infodir)

Same thing here about $(DESTDIR).

> + @list='$(infopages)'; \
> + for i in $$list; do \
> + if test -f $$srcdir/$$i; then file=$$srcdir/$$i; \
> + else file=$$i; fi; \
> + inst=`echo $$file | sed -e 's/^.*\///'`; \
> + echo "$(INSTALL_DATA) $$file $(DESTDIR)$(infodir)/$$inst"; \
> + $(INSTALL_DATA) $$file $(DESTDIR)$(infodir)/$$inst; \
> + done

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~