[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 261 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_ra_local trunk/subversion/libsvn_client trunk/subversion/svnlook trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_wc trunk/subversion/tests/libsvn_repos trunk/subversion/libsvn_repos trunk/subversion/libsvn_ra_dav

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-19 05:41:43 CEST

Two minor nits in case you apply this thing again:

On Thu, Oct 18, 2001 at 02:41:57PM -0500, kevin@tigris.org wrote:
>...
> +++ NEW/trunk/subversion/libsvn_repos/delta.c Thu Oct 18 14:41:57 2001
> @@ -46,6 +46,7 @@
> apr_hash_t *source_rev_diffs;
> svn_fs_root_t *target_root;
> svn_boolean_t text_deltas;
> + svn_boolean_t recurse;
> int target_is_rev;
> };
>
> @@ -171,6 +172,7 @@
> const svn_delta_edit_fns_t *editor,
> void *edit_baton,
> svn_boolean_t text_deltas,
> + svn_boolean_t recurse,
> apr_pool_t *pool)
> {
> void *root_baton;
> @@ -232,6 +234,7 @@
> c.source_rev_diffs = src_revs;
> c.target_root = tgt_root;
> c.target_is_rev = svn_fs_is_revision_root (tgt_root);
> + c.recurse = recurse;
> c.text_deltas = text_deltas;
>
> /* Set the global target revision if the target is a revision. */
> @@ -968,105 +971,120 @@
> && ((s_entry = apr_hash_get (s_entries, key, klen)) != 0))
> {
> int distance;
> + int is_dir;
> + svn_fs_is_dir(&is_dir, c->target_root, t_entry->name, subpool);

Should be checking for errors here. If you don't want to, then leave a
comment why.

>...
> +++ NEW/trunk/subversion/libsvn_ra_dav/fetch.c Thu Oct 18 14:41:57 2001
> @@ -1314,6 +1314,7 @@
> void **report_baton,
> svn_revnum_t revision,
> svn_stringbuf_t *target,
> + svn_boolean_t recurse,
> const svn_delta_edit_fns_t *editor,
> void *edit_baton,
> svn_boolean_t is_status)
> @@ -1388,6 +1389,18 @@
> }
> }
>
> + /* mod_dav_svn will assume recursive, unless it finds this element. */
> + if (!recurse)
> + {
> + s = apr_pstrdup(ras->pool, "<S:recursive>no</S:recursive>");
> + status = apr_file_write_full(rb->tmpfile, s, strlen(s), NULL);

There is no reason to copy a constant string onto the heap.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006

This is an archived mail posted to the Subversion Dev mailing list.