[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 245 - trunk/subversion/mod_dav_svn

From: <cmpilato_at_collab.net>
Date: 2001-10-16 15:50:57 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> > * repos.c
> >
> > (dav_svn_parse_working_uri): Allow URIs with only an activity ID
> > (not followed by a slash and a path), and assume that they refer to
> > the root of the repository.
>
> Can you elaborate on exactly what the problem was? I'm not sure I
> understand.

It's exactly as I had guessed, and what I told you yesterday morning.
The mod_dav code canonicalizes URIs, but then certain codepaths enter
this function which was expecting the last portion of the URI to be of
the form: GUID/REPOS_PATH

Well, if the REPOS_PATH is the root, or "/", and we've stripped all
trailing slashes, then this URI is really just going to end with the
GUID. Previously, we were doing a naive check for the presence of a
slash character -- if it's there and not the first character, this URI
portion is cool, else it's malformed. Now, we assume that if we don't
see a slash, we are looking at GUID (+ an implied root repos path).

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:44 2006

This is an archived mail posted to the Subversion Dev mailing list.