[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: Compile warnings on Win32

From: Mats Nilsson <mats.nilsson_at_xware.se>
Date: 2001-10-11 12:01:25 CEST

Mike wrote:

>I tracked the error down to import_dir and noticed the similarity with
>an earlier problem in apache 2.16.
>apr_dir_read (&this_entry, APR_FINFO_NORM, dir) sometimes fails down in
>win32/filestat.c:more_finfo
>
>The import seems to work successfuly with the temporary code change to
>import_dir:
> for (apr_err = apr_dir_read (&this_entry, APR_FINFO_NORM, dir);
> //APR_STATUS_IS_SUCCESS (apr_err); //mpg
> apr_err != 22518;
> apr_err = apr_dir_read (&this_entry, APR_FINFO_NORM, dir))

FYI, I reported the following a while ago on this list (re: WinNT svn
import issue)

[...]

libsvn_client/commit.c (import_dir), the calls to apr_dir_read takes a
parameter APR_FINFO_NORM, indicating that all of the files attributes are
to be retrieved. This might be fine on a *nix system, but on WinNT
requesting dev and inode doesn't make sense.

Replacing APR_FINFO_NORM with (APR_FINFO_NORM & ~APR_FINFO_IDENT) solves
the problem, but maybe this is still an overkill. Wouldn't APR_FINFO_DIRENT
be enough?

Mats

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:44 2006

This is an archived mail posted to the Subversion Dev mailing list.