[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 200 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-04 12:18:04 CEST

On Wed, Oct 03, 2001 at 02:38:06PM -0500, sussman@tigris.org wrote:
>...
> --- OLD/trunk/subversion/libsvn_wc/props.c Wed Oct 3 14:38:05 2001
> +++ NEW/trunk/subversion/libsvn_wc/props.c Wed Oct 3 14:38:05 2001
>...
> @@ -987,6 +1045,28 @@
> property into it. */
> apr_hash_set (prophash, name->data, name->len, value);
>
> + /* If hash is empty, don't write out a propfile.
> + In fact, make sure that the propfile is -deleted-. */
> + if (apr_hash_count (prophash) == 0)
> + {
> + svn_stringbuf_t *propfile_path;
> + enum svn_node_kind kind;
> +
> + SVN_ERR (svn_wc__prop_path (&propfile_path, path, 0, pool));
> + SVN_ERR (svn_io_check_path (propfile_path, &kind, pool));
> + if (kind == svn_node_file)
> + {
> + apr_status_t status = apr_file_remove (propfile_path->data, pool);
> + if (status)
> + return svn_error_createf (status, 0, NULL, pool,
> + "can't delete propfile '%s'",
> + propfile_path->data);

Whoop! Another case here. Should be checking for ENOENT.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:44 2006

This is an archived mail posted to the Subversion Dev mailing list.