local vs url style (was: Re: poor Brane)

On Tue, Oct 02, 2001 at 02:13:37AM +0200, Branko �ibej wrote:
>...
> libsvn_wc/adm_crawler.c:report_revisions() recursively crawls the
> working copy. It keeps splicing the path and entry names together in
> svn_path_local_style, as it must, if it wants to read entries and stuff
>
> Then, if it finds an interesting file, it calls reporter->set_path
> (libsvn_ra_dav/fetch.c:reporter_set_path()), which writes that path
> straight into the REPORT body -- without changing it to URL style first.
> Oops.
>
> Now, the "obvious" solution is to convert the local paths to URLs in the
> ra_dav reporter callbacks. But I have no opinion about whether it's the
> correct solution.

I believe the correct solution is to specify that the paths that cross the
editor and reporter vtables should be in the URL style.

"Why?" you ask? Who says that the files are in the local filesystem? So why
should they be in the the local_style?

Thus, the WC should be assembling paths in the URL style for passing thru
the vtable. Given that it must assemble the paths in a relative fashion
anyhow (we certainly aren't passing abs paths thru), then it can simply
assemble them using the URL style.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org