[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 185 - trunk/subversion/libsvn_delta

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-10-01 12:12:08 CEST

On Fri, Sep 28, 2001 at 08:16:28PM -0500, brane@tigris.org wrote:
> Author: brane
> Date: 2001-09-29 01:16 GMT
> New Revision: 185
>
> Modified:
> trunk/subversion/libsvn_delta/svndiff.c
> trunk/subversion/libsvn_delta/vdelta.c
> Log:
> Fix the last signed/unsigned comparison warnings.
>
> * vdelta.c (create_hash_table): Use apr_size_t instead of int.

Um... no. "i" represents a bucket or slot number. It is not a memory size,
so it shouldn't be an apr_size_t.

Again: this falls back to an improper param declaration. "num_slots" should
be an (unsigned) integer of some kind.

> * svndiff.c (write_handler, ): Likewise, and add one cast to apr_size_t.
> (Should some of the types be apr_ptrdiff_t instead of apr_size_t?)

If the value could be negative, then sure. But apr_size_t should be fine.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:43 2006

This is an archived mail posted to the Subversion Dev mailing list.