[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 178 - trunk/subversion/clients/win32/svn_com

From: Bill Tutt <rassilon_at_lyra.org>
Date: 2001-09-28 23:49:07 CEST

I'm afraid I missed what the getAll parameter does, but you almost got it right.

You should use VARIANT_BOOL instead of BOOL for COM boolean parameters that need to be IDispatch friendly.

And given that you have an incoming VARIANT_BOOL, you need to convert from a VARIANT_BOOL to a normal BOOL.

E.g:
.... VARIANT_BOOL vbGetAll, ...)

BOOL getAll;

getAll = (vbGetAll != VARIANT_TRUE ? FALSE : TRUE);

The reason you do this is because VARIANT_TRUE is -1 as opposed to TRUE which is 1.

FYI,
Bill

"Though we are not now that strength that in old days moved Earth and Heaven, that which we are we are; One equal temper of heroic hearts made weak by time and fate but strong in will to strive, to seek, to find, and not to yield." -- Tennyson

-----Original Message-----
From: Branko ├łibej [mailto:brane@xbc.nu]
Sent: Friday, September 28, 2001 2:31 PM
To: Bill Tutt
Cc: dev@subversion.tigris.org
Subject: Re: svn commit: rev 178 - trunk/subversion/clients/win32/svn_com

Bill, since you're the author of this code, could you check that I did
the right thing? The API change might not be the right thing to do, and
it's entirely possible I goofed the change -- COM isn't one of my
stronger points.

    Thanks,

brane@tigris.org wrote:

>Author: brane
>Date: 2001-09-28 21:22 GMT
>New Revision: 178
>
>Modified:
> trunk/subversion/clients/win32/svn_com/SVN.cpp
> trunk/subversion/clients/win32/svn_com/SVN.h
> trunk/subversion/clients/win32/svn_com/SVNCOM.idl
>Log:
>Get the COM wrapper to compile after the svn_wc_statuses API change.
>
>* SVNCOM.idl (ISVNWorkingCopy::wc_statuses): New parameter getAll.
>* SVN.h (CSVNWorkingCopy::wc_statuses): Likewise.
>* SVN.cpp (CSVNWorkingCopy::wc_statuses): Likewise; pass to
>svn_wc_statuses.
>

-- 
Brane ─îibej   <brane_at_xbc.nu>            http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.