[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: revision 145 - trunk/subversion/libsvn_repos

From: Bill Tutt <rassilon_at_lyra.org>
Date: 2001-09-24 21:43:57 CEST

After you do that, other compilers will complain about the void *
parameter being an unused local variable. :)

Bill

-----Original Message-----
From: Greg Stein [mailto:gstein@lyra.org]
Sent: Monday, September 24, 2001 12:40 PM
To: svn@subversion.tigris.org
Subject: Re: svn commit: revision 145 - trunk/subversion/libsvn_repos

On Mon, Sep 24, 2001 at 01:19:27PM -0500, cmpilato@tigris.org wrote:
>...
> --- OLD/trunk/subversion/libsvn_repos/node_tree.c Mon Sep 24
13:19:27 2001
> +++ NEW/trunk/subversion/libsvn_repos/node_tree.c Mon Sep 24
13:19:27 2001
> @@ -310,10 +310,6 @@
> window_handler (svn_txdelta_window_t *window, void *baton)
> {
> struct window_handler_baton *whb = baton;
> -
> - if (window != NULL)
> - whb->node->text_mod = TRUE;

An alternative fix would be to lose the "window != NULL" condition. But
that's just for posterity; I think the fix you made is better.

Note that you should probably toss the whb declaration. I bet some
compilers are going to warn about an unused var.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
For additional commands, e-mail: svn-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.