Re: DAV updates

On Fri, Sep 21, 2001 at 10:32:33AM -0500, cmpilato@collab.net wrote:
>...
> (2) Suck! Does that mean we're always GETting the whole file even
> if one character has changed?!

Yes.

> Well, Ben ran ethereal during an update, and put our fears of (2) to
> rest:
>
> GET /testing/cmpilato-test/$svn/ver/358.2/bendir7/campaign1 HTTP/1.1
> User-Agent: SVN/M3 neon/0.15.3
> Keep-Alive:
> Connection: TE, Keep-Alive
> TE: trailers
> Host: svn.collab.net
>
> HTTP/1.1 200 OK
> Date: Fri, 21 Sep 2001 15:20:20 GMT
> Server: Apache/2.0.26-dev (Unix) DAV/2 SVN/M3
> ETag: "358.2"
> Accept-Ranges: bytes
> Content-Length: 5
> Keep-Alive: timeout=15, max=100
> Connection: Keep-Alive
> Content-Type: text/plain; charset=ISO-8859-1
>
> moob
>
> "moob" is the diff between what Ben had on disk, and what was current
> in the HEAD of the repository. So we did actually get only the diff,
> not the whole contents of the file `campaign1'.

No. That is not a valid SVNDIFF. You fetched the contents of the file. The
question then becomes "what happened to the file?" Seems remniscent of
Kevin's problems with his commits.

> But we're scratching our heads as to how mod_dav_svn knew to only send
> the diff? GregS? Someone? What are we overlooking here?

That campaign1 had "moob" for its contents and that you fetched them. That
compaign1 wasn't what you thought it was.

Now... regarding fetching of diffs. That gets much tricker. We have to
generate some additional headers in the GET request that tells mod_dav_svn
"I have <this> revision *and* I can accept <these> diff formats, so send me
a diff." We would then generate a diff somehow and send it down the wire.

One of the key indicators that you did not get a diff is the Content-Type
header in that response. When a diff is sent, the C-T will reflect that.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org