Re: Re: Updating svn.collab.net

On Thu, Sep 20, 2001 at 08:56:31AM +0200, Sander Striker wrote:
> I forwarded the entire thread to dev@apr.apache.org.
> Seems like Justin picked up the unix side (he posted
> a patch).
>
> Bill, could you post your win32 patch in unified diff
> format to the apr list?
>

Alright, what is the best way to introduce this to svn_io_run_cmd

I am thinking one of two things, either

1) Return an error if non-zero exit
2) Add an out parameter to svn_io_run_cmd which returns the status.

I am leaning towards the latter for a couple of reasons
a) Since we need to use accessor macros to get the value, we can't return
its exact value in an error-code.
b) Most users of svn_io_run_cmd will ignore it, since diff and patch both
return non-zero in many of our normal uses.

i.e. diff returns 0 if no difference, 1 if difference, 2 if problems and
patch returns 0 if all successful, 1 if rejects, 2 if problems.

Will work on 2) unless people advise otherwise.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~