[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_path_canonicalize

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2001-09-20 03:05:18 CEST

On Wed, Sep 19, 2001 at 06:02:28PM -0700, Greg Stein wrote:

> It sounds like args_to_target_array should take a path style. Sometimes the
> args are URLs, and sometimes they are paths.
>
> Hmm... actually, they can be mixed. Oh, agony. Consider this on Windows:
>
> C:\> svn import http://example.com/repos/test C:\src\test
>
> IMO, args_to_target_array should *not* canonicalize the arguments. That
> should be deferred to where we know what style those arguments are. In this
> case, the first arg is url_style and the second arg is local_style.
>
> Good find!

ok, i'll have my patch remove the canonicalize call from there...

> >...
> > > in subversion/libsvn_ra_dav/fetch.c:we're passing in
> > > svn_path_url_style when at least sometimes we're giving it a path.
> > > i've changed it to svn_path_local_style and it seems to work fine now.
> >
> > this change is most likely bogus... it seems to be passing a path
>
> Yes.
>
> > that exists on the server, but it's not a url... a
> > printf("url = %s\n") in my_basename will yield this when you try to
> > checkout...
> >
> > url = /repos/svn/$svn/bc/120/.svnignore
>
> It is a *relative* URL. Thus, it is quite a valid URL, and should continue
> to be url_style.
>
> Everything in ra_dav is URL-based. There is nothing in there that should
> manipulate local paths.

ok, i had forgotten about relative url's... i'll just include a check
for the url_style case for that... no problem.

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.