[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: file-descriptor probs.

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2001-09-20 01:43:39 CEST

On Thu, Sep 20, 2001 at 01:22:42AM +0200, Branko �ibej wrote:
> Ben Collins-Sussman wrote:
> >The new system
> >--------------
> >
> > * The tmpfile is created by libsvn_client; ra_dav invokes a
> > callback, and the client returns only an apr_file_t that has
> > *already* been unlinked. (APR_DELONCLOSE).
> >
> > * in commit_stream_close,
> >
> > - the apr_file_t is rewound using apr_file_seek()
> > - the filedescriptor is discovered using apr_os_file_get()
> >
> ... which won't work on Windows, where an apr_os_file_t is a HANDLE, not
> a Unix-like file descriptor.
> I don't know how to solve this except by moving neon on top of APR, or
> changing neon's interface to use some kind of generic stream, like we do
> in Subversion.

The problem is that neon offers a generic interface to "pull" request
bodies (i.e., you provide a callback, neon calls it to get a block of
data). But SVN wants a "push" interface: it's hard to offer this
without a complete rewrite of the neon request code (which to be fair is
needed anyway).

Having neon support APR just makes the workaround for this API mismatch
a bit easier.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.