[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug, bug, bug...I think

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-19 03:50:50 CEST

On Tue, Sep 18, 2001 at 03:42:35PM -0500, cmpilato@collab.net wrote:
> I think I've found a little buglet in Subversion, but I'd like to see
>...
> Here's my guess (if I may hazard one): the character '#' is not
> URI-escaped, so Apache is freakin'. I know we certainly do NOT store
> "http://localhost/repos/test/%23foo" in our entries file.

Yup. We aren't URI-escaping the value properly.

Note that we would need to URI-escape the value *before* appending the
component onto the parent dir's URI. It is impossible to post-process a URI
and escape it.

Thus: it extends a bit further than ra_dav, unfortunately :-(

Log an issue, and we probably ought to mention it in the "inconveniences"
that URI-special characters are offlimits in files for now.

Here is the BNF for path components in a URI. "pchar" is a character in a
path component.

      pchar = unreserved | escaped |
                    ":" | "@" | "&" | "=" | "+" | "$" | ","

      unreserved = alphanum | mark
      
      mark = "-" | "_" | "." | "!" | "~" | "*" | "'" | "(" | ")"

Note that "escaped" doesn't really apply to what users can put in their
paths, so that really means the set of characters is:

    alphanum | mark | ":" | "@" | "&" | "=" | "+" | "$" | ","

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006

This is an archived mail posted to the Subversion Dev mailing list.