[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_fs_contents_changed

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2001-09-18 13:26:36 CEST

On Mon, Sep 17, 2001 at 11:44:44PM -0500, cmpilato@collab.net wrote:
> Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
> > while reading over the subversion source code this weekend, i noticed
> > that svn_fs_contents_changed() was taking a pointer to an int as one
> > of its arguments, when it was using it as a bool. this patch changes
> > it to use an svn_boolean_t for clarity and updates the only place in
> > the tree that calls it. maybe it'll save someone else from a moment
> > of confusion later on.
>
> Sorry, I have to -1 this one (on Jim's behalf). We've been here
> before, and the FS interface conistently ignores the existence of
> svn_boolean_t and svn_string*, by design. If everyone wants to change
> it, I certainly won't care, but I know this has been visited before
> with respect the libsvn_fs.

ok, no big deal.

-- 
garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006

This is an archived mail posted to the Subversion Dev mailing list.