[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: authentication progress...

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-18 02:01:28 CEST

On Mon, Sep 17, 2001 at 04:32:17PM -0500, Ben Collins-Sussman wrote:
>...
> /* Open a temporary file FILENAME in the working copy.
> Arguments are identical to apr_file_open(), except that FILENAME
> is presumed to be a basename (instead of a whole path.) */
> svn_error_t *(*open_tmp_file) (apr_file_t **fp,
> const char *filename,
> apr_int32_t flag,
> apr_fileperms_t perm,
> void *callback_baton,
> apr_pool_t *pool);

Maybe just call the parameter BASENAME to begin with? :-)

I am also thinking that the flags and perms can be defaulted/provided by the
callback. I can't imagine RA needing to use some kind of fine-grained
changes over that.

Specifically, perms would APR_UREAD|APR_UWRITE|APR_UEXECUTE (unreadable by
group or world). Note this is a *temp* file, so those perms should be fine.

Looking at the flags... there are two defined by APR that could be
important: APR_BINARY and APR_BUFFERED. I would recommend RA-specified
flags, which are then mapped into APR flags. That will keep people from
thinking that they need to specify a bunch of the other ones.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006

This is an archived mail posted to the Subversion Dev mailing list.