On Mon, Sep 17, 2001 at 04:32:17PM -0500, Ben Collins-Sussman wrote:
> /* A protocol which needs a username and password (used by ra_dav)
> (matches type SVN_RA_AUTH_SIMPLE_PASSWORD above.) */
> typedef struct svn_ra_simple_password_authenticator_t
> {
> /* Get a username from the client. */
> svn_error_t *(*get_username) (char **username,
> void *auth_baton,
> apr_pool_t *pool);
>
> /* Get a password from the client. */
> svn_error_t *(*get_password) (char **password,
> void *auth_baton,
> apr_pool_t *pool);
>
> /* If authentication was successful, tell the client to store the
> USERNAME or PASSWORD. */
> svn_error_t *(*store_username) (const char *username,
> void *auth_baton);
> svn_error_t *(*store_password) (const char *password,
> void *auth_baton);
>
> } svn_ra_simple_password_authenticator_t;
In the above code couldn't the get_username and get_password be collapsed into
a single get_auth(username, password, auth_baton, pool)? The same could go
for the store method. Is there a reason they need to be separate?
thanks,
- Dale Thatcher
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006