[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: state-of-union #2

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2001-09-17 15:02:24 CEST

On Mon, Sep 17, 2001 at 01:40:19AM -0500, Will Andrews wrote:
> > i've already put together a diffutils port, so we can get gdiff, and
> > it's been submitted as a pr. gnu patch also exists as a port. i
> > don't know what the exact behavior subversion requires is, but IIRC
> > freebsd's version purposefully changes it.
> Well, I would prefer to fix this here and now in the subversion
> tree, not because it's the harder way to do the fix ;) but
> because it's the Right Way(tm) to fix it. I.e. I'd prefer to fix
> gnu-[diff,patch].sh so they actually test the diff/patch binaries
> on a system.. 'cause who knows what other systems might have a
> useful diff/patch for subversion and may not be able to use GNU's
> version for some reason? I.e. administrator concern, outdated
> OS, blah blah. :)

another thought. while it would be good to fix the
gnu-{patch, diff}.sh files as you describe, remember that the reason
they exist is that the version currently on FreeBSD was found to not
work. if you run the tests with the FreeBSD versions you will get
spurious failures that aren't bugs in Subversion, they are related to
assumptions about how diff and patch will work.

so yeah, it'd be good to do more than 'check for gnu diff/patch', but
we'll still have to either use gpatch/gdiff on FreeBSD or remove the
changes to them in the FreeBSD tree (since FreeBSD does actually have
GNU patch/diff, but changes them slightly, in a way that subversion
doesn't like).

garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.