[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Test cases broken when builddir != srcdir

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-15 11:54:45 CEST

On Fri, Sep 14, 2001 at 05:12:56PM -0700, Mo DeJong wrote:
> Hi all.
>
> I tried to run the automated test cases in a builddir that is not the srcdir
> and hit a wall. Some of the test case shell scripts are written to assume
> that the builddir is the same as the srcdir. In addition, there are some
> really nasty chmod hacks in the toplevel Makefile that don't work.
> How should we fix this? There are a couple of approaches we could try.
>
> 1. Leave the .sh scripts in the srcdir and pass in the builddir.
> 2. Copy the .sh scripts into the builddir and pass in the srcdir.
> 3. Do some cute trick like storing the srcdir or builddir in a file
> that the scripts know how to access with a relative path.
>
> I took a quick hack at option #2 minus the changes to the actual .sh
> files. Does this look reasonable to folks?

I don't think we should be needlessly copying things around.

IMO, we should always pass in the source directory to the scripts/programs.
It was doing that at one point, but Ben ripped it out. He didn't like some
part of parsing the cmdline args, if I recall correctly.

The builddir should always be the cwd. That is what the "cd" is in there
for.

Granted, maybe it is buggy :-) ... but the idea of copying stuff around just
to deal with this feels wonky.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006

This is an archived mail posted to the Subversion Dev mailing list.