Re: Http proxy patch [Was: Re: [Dale Thatcher <subversion@dalethatcher.com>] Posting to the list]

Dale Thatcher wrote:

>Hi,
>
>Thanks for the feedback on the patch. According to ne_auth.h the use of
>malloc is required. It's already used in the request_auth function in
>session.c and get's freed almost immediately by the neon library.
>
Point. I think this particular malloc (in request_proxy_auth) can stay.
But *please* don't use "l" for variable names. "len" or some such would
be better.

And you should use apr_pstrdup where appropriate, instead of using
apr_pcallod&memcpy. There's also an apr_pstrndup, if you have to extract
a substring.

>I'll make the changes so that you can pass in a proxy URI with --http-proxy=
>and resubmit the patch. Is the URI format ok?
>
Someone else will have to answer that one. Greg? Joe?

-- 
Brane �ibej   <brane_at_xbc.nu>            http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org