[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: mod_ssl broken

From: William A. Rowe, Jr. <wrowe_at_rowe-clan.net>
Date: 2001-09-10 14:36:37 CEST

From: "Sander Striker" <striker@apache.org>
Sent: Monday, September 10, 2001 3:24 AM

> >> I've looked into this slightly, and the underlying problem is that
> >> ap_merge_per_dir_configs finds a previous cached merge (for /?) and
> >> tries to use it but the entry for mod_ssl is NULL. The URL, btw, is
> >> /svn.
> >
> > This is very, very odd. Would someone please post the svn
> > create/merge dir config
> > code, just in case it's clobbering a sibling?
>
> #define INHERIT_VALUE(parent, child, field) \
> ((child)->field ? (child)->field : (parent)->field)
>
> Looks ok to me...

Looks OK to me too...

Who wants to toss together a patch to pull all the helper code from mod_ssl,
change it from eastern to western European, and drop it back in the right
place (AP_ decorated) such as ap_config.h?

If _we_ need these sort of helpers...

#define cfgMerge(el,unset) new->el = (add->el == (unset)) ? base->el : add->el
#define cfgMergeArray(el) new->el = apr_array_append(p, add->el, base->el)
#define cfgMergeTable(el) new->el = apr_table_overlay(p, add->el, base->el)
#define cfgMergeCtx(el) new->el = apr_table_overlay(p, add->el, base->el)
#define cfgMergeString(el) cfgMerge(el, NULL)
#define cfgMergeBool(el) cfgMerge(el, UNSET)
#define cfgMergeInt(el) cfgMerge(el, UNSET)

then apparently (as your example shows) the rest of the world needs these as well.

Bill

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:40 2006

This is an archived mail posted to the Subversion Dev mailing list.