[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: state of union

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-08 01:33:15 CEST

On Thu, Sep 06, 2001 at 10:25:21AM -0500, Ben Collins-Sussman wrote:
> Mike and I have decided to dedicate ourselves to learning the network
> layer (libsvn_ra_dav and mod_dav_svn). Most of our Big Bugs are with
> the network layer, and right now only Greg and Joe are able to work in
> this area of code... in general, not a good situation for any project
> to be in.

I've been saying that for a while now :-)

> I'd hate to think would happen if they got hit by a bus. :-)

It would hurt. A lot.

> Greg is leaving town for a little while, so Mike and I will
> (hopefully) being bouncing questions off of Joe, while adding tons of
> comments and docstrings to the networking code.

I'm obviously on email, once or maybe twice a day.

> * get our log-messages properly XML-escaped (475)

See apply_log_message() in commit.c. Use svn_xml_escape_string().

Arguably, Neon should be XML-escaping the value since it is embedding it
within an XML document. Joe and I went around on the character encoding
issue a while back, but XML-escaping is a separate issue. If/until Neon
changes its behavior, we can do it in commit.c.

> * start studying all networking code, adding comments.

Comments? hehe. If it doesn't have a comment, then I didn't think it needed
one. Isn't that the way things work? ;-)

> * immediate goal: get dav props working (382)
> * this fixes 'binary' props not coming down to us
> * this allows us to get 'svn:ignore' props on dirs too.

No ideas on this one. Would need to look at the network traffic. It is
probably related to the wonkiness on the server, dealing with the mod_dav
API for accessing dead props. I have written about 90% of the mod_dav and
mod_dav_fs code to change the API. It needs completion, testing, and then to
be checked into Apache; then we need to update mod_dav_svn. That should make
things much more robust.

Note that you won't be able to get user-defined props working. Just not
doable until the API upgrade. (doable, but not nicely would be more
accurate) The problem is related to the METADATA pseudo-property and
namespace management.

> * 475: log messages probably aren't being XML-escaped.

They aren't; I just checked.

> * 484: ra_dav:fetch.c:reporter_abort_report() must abort txn.

DELETE the activity. Of course, the server doesn't understand that, but that
is the correct wire marshalling.

> * 455: import doesn't work over ra_dav

No idea.

> * 411: cannot checkout arbitrary revision, only HEAD.
> (although 'svn up -r N' works as a substitute)

See other mail.


Greg Stein, http://www.lyra.org/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:40 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.