[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Commit

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2001-09-04 20:04:56 CEST

Garrett Rooney <rooneg@electricjellyfish.net> writes:

> > Commit: Revision 35: foo.c bar.c baz.h [...]
> >
> > So we can keep "35" as the unique commit identifier, and people can
> > still search for filenames in subjects.
>
> out of curiosity, what's the advantage to having the rev number in the
> subject? it strikes me that if you need the rev #, you're probably
> looking at the rest of the email that describes the changes, so you
> could just put it there. i imagine you could use it to order the
> mails, but they're dated, so that's not really necessary...

You should look at our commit mails. The body already contains the
author, date, revision number, modified files, log message, and
unified diff. Absolutely everything is in there. Really, this is a
bikeshed discussion about "what's a convenient subject line?".
Anything in the subject line is already redundant.

That said, we're trying to promote a habit of talking about commits as
unique objects. Really, "revision 35" is the name of a certain
changeset. In the same way we talk about "issue 480", it's nice to be
able to say "oh yeah, revision 35 fixed issue 480."

Of course, the *other* reason we want the revision number in the
subject line is threading. Dates aren't enough. We need clean
subjects for clean threading.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:39 2006

This is an archived mail posted to the Subversion Dev mailing list.