[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_wc ...

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-03 13:49:37 CEST

On Sun, Sep 02, 2001 at 09:45:46PM +0200, Sander Striker wrote:
>...
> > Right. I'd like to take on this one tomorrow (Amsterdam time), if you are
> > alright with it. It is only a small patch that will get the behaviour of
> > visiting each directory only once (by adjusting the sorting).
>
> I've cooked up a patch that I think will do the trick. Ofcourse it needs
> to be tested.
>
> It has (IMO) one downside: it assumes that strings are NUL terminated.

Why would you think they aren't? By definition, anything in an
svn_string(buf)_t is null-terminated. (see svn_strings.h)

> OTOH this isn't going to be a big problem when I look at the task
> list and issue #406.

It isn't a problem now :-)

> Oh, I also removed 'else' statements where there was only one path
> for the code to take. The ones like these IOW:

No problem. I do the same.

>...
> I don't know if this patch is really needed, but I do think that
> visiting a dir only once justifies the extra cost of sorting like
> this.

Yah. Makes sense.

The patch looks reasonable. I'll let the WC guys investigate more closely,
tho...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:39 2006

This is an archived mail posted to the Subversion Dev mailing list.