Greg Hudson <ghudson@MIT.EDU> writes:
> > Instead, let's add a flag to open_stream(svndiff_stream). The flag
> > will signify whether close_stream() should error on pending data or
> > just ignore it.
>
> I find this a very confusing way of thinking about the problem.
>
> The issue is that sometimes we want to parse an incomplete svndiff
> stream (which is probably a design flaw; it would be better to have
> the concept of a seekable svndiff parser, but that's more work). If
> you're going to make a flag to allow this, call it something like
> "incomplete_stream", not "error_on_early_close".
Sounds fine to me; go ahead and commit that change, imho. I assume no
one else objects to this clarifying rename.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:37 2006