Branko =?ISO-8859-2?Q?=C8ibej?= <brane@xbc.nu> writes:
> [ Note: I'll make sure these patches make it into Subversion and APR,
> but after M3.]
Bless you, Branko. (And C. Scott Ananian for *writing* it, of
course!)
-K
> O.K., I guess we're almost there. I still have a few nits, but nothing
> really insurmountable.
>
> The APR stuff:
>
> * APR code should be indented 4 spaces, not 2
> * I don't like this idea of working around bugs in the system's
> strptime implementation. If it's buggy, don't use it -- the user
> can upgrade her libc if she's not happy with the replacement. This
> implies that the autoconf test should do more than just check that
> strptime is available.
>
>
> The Subversion stuff:
>
> * Please do away with <libintl.h> for now. Your idea to just
> "#define gettext(X)" X is O.K.
> * I think the copyright in svn_date.c should be to CollabNet. Karl,
> that's your call, I guess.
>
>
>
> Otherwise, it looks great. Thanks for taking the time to get this done!
>
>
> --
> Brane �ibej <brane_at_xbc.nu> http://www.xbc.nu/brane/
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:37 2006