[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Couple of build system points

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2001-08-27 18:30:47 CEST

Hey All,

A couple of issues I've found regarding the build system.

1) Make extraclean:
When doing make extraclean, we skip neon. Firstly, we also need to skip
db/dist. Secondly, we should 'make distclean' instead.

I plan on fixing this by the patch at the end of this mail.

2) When the db-in-tree is built, we need to do a couple of things:
        a) Make sure it is a valid version
        b) Make sure it finishes building before we try to link against it(think
        make -j here).

Not sure of the best approach here.

3) When we have no db or apache, we need to make sure that the install
        target doesn't depend on the fs/module components, or else we try
        to build it at install time.

My plan for this was to change the way build.conf works, by combining the
group and install options. Thus we would have install values of
lib, fs-lib, bin, fs-bin, sbin, fs-sbin, test, fs-test. Then change
gen-make.py and configure.in to make rules for each of the existing install
values, and substitute the ones that are needed back into the makefile. What
do you all think about this approach and the patch below?

Index: Makefile.in
===================================================================
RCS file: /usr/local/tigris/data/helm/cvs/repository/subversion/Makefile.in,v
retrieving revision 1.28
diff -u -r1.28 Makefile.in
--- Makefile.in 2001/08/20 20:32:01 1.28
+++ Makefile.in 2001/08/27 16:33:04
@@ -150,14 +150,19 @@
             echo "------ completed $$target in $$i"; \
         done;
 
-### temporary hack. Neon does not have an "extraclean"
+### temporary hack. Neon does not have an "extraclean" and neither does db
+### If we don't have extraclean -- do the next best thing.
 external-extraclean:
         @list='$(EXTERNAL_PROJECT_DIRS)'; \
         for i in $$list; do \
- if test "$$i" != "neon"; then \
- echo "------ making extraclean in $$i"; \
- (cd $$i && $(MAKE) extraclean) || exit 1; \
- echo "------ completed extraclean in $$i"; \
+ if test "$$i" != "neon" && test "$$i" != "db/dist"; then \
+ echo "------ making extraclean in $$i"; \
+ (cd $$i && $(MAKE) extraclean) || exit 1; \
+ echo "------ completed extraclean in $$i"; \
+ else \
+ echo "------ making distclean(no extraclean) in $$i": \
+ (cd $$i && $(MAKE) distclean) || exit 1; \
+ echo "------ completed distclean(no extraclean) in $$i"; \
             fi; \
         done;
 

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:37 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.