Re: ra_dav mass-commit status

Greg Stein <gstein@lyra.org> writes:

> Note that the first change doesn't trigger it. It is the second. And I just
> verified that using ra_local succeeds... hmm.

Hey, Greg, check how svn_txdelta_parse_svndiff() is used in
libsvn_fs/reps-strings.c:rep_read_range(). I'm trapping that specific
error and ignoring it because I'm sending data in chunks, and I *know*
there are times when I won't be sending the whole of the svndiff
data. I'm not sure that mod_dav_svn is doing anything special when
the stream is closed -- would that be dav_svn_close_stream()?

Now, I don't know which is better: to catch this specific error (it is
generated in exactly one place in the code), or to change the
close_handler for svndiff stuffs so that it stops caring about the
fact that the data ended early. I do think it's good to have that
final integrity check there, but if it is going to complicate the code
in other ways, I'm not so sure.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:37 2006