Re: [PATCH] complete: APR-ized svn_parse_date replacement

On Mon, Aug 27, 2001 at 01:17:52AM +0200, Branko �ibej wrote:
>...
> * APR code should be indented 4 spaces, not 2

Yes. The two styles are quite different. The spacing is probably the biggest
thing. Preferably, the open brace on the same line as the previous
construct. with those two items, it will be "more than close enough."

> * I don't like this idea of working around bugs in the system's
> strptime implementation. If it's buggy, don't use it -- the user
> can upgrade her libc if she's not happy with the replacement. This
> implies that the autoconf test should do more than just check that
> strptime is available.

Agreed. I saw the runtime stuff and though, "do the check in autoconf to
determine whether to do the runtime adjustment." But an autoconf check to
fully replace is an even better idea.

>...
> * I think the copyright in svn_date.c should be to CollabNet. Karl,
> that's your call, I guess.

Absolutely. It cannot be accepted without that. If that is a problem in any
way (flat out impossible, or queasy, or questions, or whatever), then we can
discuss it more.

[ yah, I don't work for CollabNet, but I'm more than familiar with the
  situation and goals to know that this is necessary ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org