Re: CVS update: MODIFIED: libsvn_wc ...

On Wed, Aug 22, 2001 at 05:29:57PM -0000, sussman@tigris.org wrote:
> User: sussman
> Date: 01/08/22 10:29:57
>
> Modified: subversion/libsvn_wc adm_crawler.c
>...
> + /* Catch -any- error that happened during a commit-crawl.
> + Be sure to unlock any working-copy directories that may have
> + become locked during the crawl. */
> + if (err)
> + {
> + err2 = remove_all_locks (locked_dirs, pool);
> + if (err2)
> + return svn_error_quick_wrap
> + (err, "commit failed: uhoh, unable to remove all wc locks.");
> + else
> + return svn_error_quick_wrap
> + (err, "commit failed: wc locks have been removed.");
> + }
> +
> + /* Successful crawl: remove all the lockfiles in this case too. */
> + err = remove_all_locks (locked_dirs, pool);
> + if (err)
> + return svn_error_quick_wrap
> + (err, "commit succeeded, but unable to remove all wc locks!");
>
> return SVN_NO_ERROR;

The above code tosses the actual commit problem. The user may not be able to
figure out why it happened, clean up the WC, then try again only to have it
fail again (potentially leaving the WC unclean all over again).

I would recommend the attached patch. What do you think?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org