Re: CVS update: MODIFIED: libsvn_wc ...

On Wed, Aug 22, 2001 at 11:31:15AM -0500, Ben Collins-Sussman wrote:
> cmpilato@collab.net writes:
>
> > Ben Collins-Sussman <sussman@collab.net> writes:
> >
> > > Looking at this structure, what do you suggest? That we rename this
> > > public function to some internal name, and make
> > > svn_wc_crawl_local_mods() a "wrapper" around the whole thing, whose
> > > only purpose is to catch errors and cleanup locks? I'm amenable to
> > > that.
> >
> > Gaw, took the words right out my, er, fingers. Make
> > svn_wc_crawl_local_mods do nothing but the qsort'ing of the targets.
> >
> > Then call another function with:
> >
> > - the big if/else braces
> > - the post-fix text deltas
> > - the call to editor->close_edit.
> >
> > Finally, back in svn_wc_crawl_local_mods, the locks are removed and
> > errors are *then* propogated upwords.
>
> I'll do it, by Jove, and put back all the easy-to-read SVN_ERR macros
> into the main if-else logic. :-)

That was my thought... with the smaller wrapper, then you can continue to
use SVN_ERR macros *and* you can be guaranteed the cleanup.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org