Re: CVS update: MODIFIED: libsvn_wc ...

Ben Collins-Sussman <sussman@collab.net> writes:

> Looking at this structure, what do you suggest? That we rename this
> public function to some internal name, and make
> svn_wc_crawl_local_mods() a "wrapper" around the whole thing, whose
> only purpose is to catch errors and cleanup locks? I'm amenable to
> that.

Gaw, took the words right out my, er, fingers. Make
svn_wc_crawl_local_mods do nothing but the qsort'ing of the targets.

Then call another function with:

  - the big if/else braces
  - the post-fix text deltas
  - the call to editor->close_edit.

Finally, back in svn_wc_crawl_local_mods, the locks are removed and
errors are *then* propogated upwords.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:36 2006