Greg Stein <gstein@lyra.org> writes:
> On Tue, Aug 21, 2001 at 04:10:23PM -0000, sussman@tigris.org wrote:
> > User: sussman
> > Date: 01/08/21 09:10:23
> >
> > Modified: subversion/libsvn_wc adm_crawler.c
> > Log:
> > * adm_crawler.c (svn_wc_crawl_local_mods): replace all SVN_ERR calls
> > with blocks that cleanup lockfiles. This might resolve a
> > locked-working-copy bug seen in very large commit tests. Thanks to
> > Yoshiki Hayashi <yoshiki@xemacs.org> for noticing this problem.
>
> A more robust solution would be to have svn_wc_crawl_local_mods create the
> hash table and pass it into do_crawl_mods() (or whatever). When
> do_crawl_mods() returns, then the locks are cleared and the (error) result
> returned.
Mmmm. +1 -- this would be a maintainability win, sounds like.
Ben's network connection is jittering on and off right now (he just
got a newer, faster laptop and is setting up FreeBSD), but I told him
about your mail and he'll take a look at this solution asap.
-K
> svn_wc_crawl_local_mods is a huge routine, and that special error exit
> handling can easily be forgotten (empirically shown here). By moving the
> cleanup to a handler function, you can ensure that nobody ever forgets to
> clean up, no matter how they happen to exit the guts of the crawling.
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:36 2006