Re: CVS update: MODIFIED: svnlook ...

On Mon, Aug 20, 2001 at 05:31:42PM -0000, cmpilato@tigris.org wrote:
> User: cmpilato
> Date: 01/08/20 10:31:42
>
> Modified: subversion/svnlook main.c
> Log:
> * svnlook/main.c
>
> (INT_ERR, main): Explicitly clean up the FS before exiting.

Why is this? It sounds like you're simply painting over more subtle problems
with pool-based cleanup.

>...
> + cleanup: /* Cleanup after ourselves. */
> + if (c.txn && (! c.is_revision))
> svn_fs_close_txn (c.txn);
> +
> + if (c.fs)
> + svn_fs_close_fs (c.fs);
>
> svn_pool_destroy (pool);
> apr_terminate ();

That pool destroy right there should be exactly the same as the above two
lines. If not, then why?

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org