[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_ra_dav ...

From: Joe Orton <joe_at_manyfish.co.uk>
Date: 2001-08-16 01:25:35 CEST

Hi,

> * libsvn_ra_dav/commit.c: (commit_resource) Add cast to (void *) to make MSVC happy.
> * libsvn_ra_dav/session.c: Include apr_general.h to pick up strcasecmp prototype.

Hi, does this also make MSVC happy? Not sure why that 'locn' has to be
const at all.

Index: commit.c
===================================================================
RCS file: /usr/local/tigris/data/helm/cvs/repository/subversion/subversion/libsvn_ra_dav/commit.c,v
retrieving revision 1.66
diff -u -r1.66 commit.c
--- commit.c 2001/08/15 23:06:24 1.66
+++ commit.c 2001/08/15 23:22:14
@@ -324,7 +324,7 @@
   int rv;
   int code;
   const char *body;
- const char *locn = NULL;
+ char *locn = NULL;
   struct uri parse;
 
   if (res->wr_url != NULL)
@@ -357,12 +357,8 @@
                       "</D:activity-set></D:checkout>", cc->activity_url);
   ne_set_request_body_buffer(req, body, strlen(body));
 
- /*
- * We have different const qualifiers here. locn is const char *,
- * but the prototype is void * (as opposed to const void *).
- */
   ne_add_response_header_handler(req, "location",
- ne_duplicate_header, (void *)&locn);
+ ne_duplicate_header, &locn);
 
   /* run the request and get the resulting status code. */
   rv = ne_request_dispatch(req);
@@ -400,7 +396,7 @@
   uri_parse(locn, &parse, NULL);
   res->wr_url = apr_pstrdup(cc->ras->pool, parse.path);
   uri_free(&parse);
- free((void *)locn);
+ free(locn);
 
   return NULL;
 }

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:36 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.