Re: CVS update: MODIFIED: libsvn_subr ...

Branko Čibej <brane@xbc.nu> writes:
> I've already solved the problem. APR now has apr_implode_gmt(), which
> always returns a UTC apr_time_t, as long as the exploded time has the
> correct tm_gmtoff value. We're using this API in whatever
> svn_wc__string_to_time() has become. And I pounded APR into
> calculating the correct tm_gmtoff on all platforms I can get my hands
> on, with all TZ settings I could find defined -- see the comments in
> apr/time/unix/time.c:get_offset().
>
> Thus, this /should/ be fixed.

Oh, *you* wrote apr_implode_gmt()? I didn't realize it wasn't always
there. Thanks!

> Does this *still* not work correctly? My tests (on Linux) show that it
> does, at least the timestamps in the wc are correct.

See

   tests/libsvn_fs/fs-test.c:commit_date(), lines 3580-3624

for the problem I was having...

> The apr_time_t should always be UTC (GMT, whatever). That's what
> apr_time_now() returns, and that's what's stored in apr_finfo_t (which
> is where the values in the wc came from, originally).

Okay, thanks.

> Seriously: are you actually seeing this problem with the latest APR?

Yeah, my APR was up-to-date (or I couldn't have compiled, since
Subversion now calls your apr_implode_gmt() ).

I'll look into the problem in fs-test.c again, but feel free to beat
me to it...

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:32 2006