Anyone feel like taking issue #406? It's not a showstopper, nor is it
terribly difficult, but it would be nice to have it done and it
involves tweaks across quite a lot of code. (Also, if anyone has
comments on the proposed solution, this would be a good time to post
them.)
Here's #406's description:
There are many places where, for historical reasons, we are using
svn_stringbuf_t to pass or return constant char * data. We could
just use svn_string_t, or in some instances even go straight to
const char *. I will put "### todo" notes, referencing this issue,
in the code at some of these places. See in particular the
declarations of
svn_fs_revision_prop()
svn_fs_revision_proplist()
svn_fs__get_prop()
svn_fs__make_prop_hash()
Really, it is questionable that we even need to use svn_string_t
for property names. I believe everyone agreed informally that
const char * would be fine, and usually more convenient for
callers. If so, the fix for this issue is something like:
1. Change all property getting functions to take a const char
*name, and return by reference svn_string_t *value.
2. Change all property setting functions to take const char
*name and svn_string_t *value.
Comments? This affects not just svn_fs.h property interfaces, but
svn_delta_edit_fns_t in svn_delta.h as well, and probably some
stuff in svn_wc.h.
-Karl
------- Additional Comments From Karl Fogel 2001-07-02 09:37 -------
Note that making this change probably implies writing
svn_string_ncreate() and all that good stuff, or else doing it
inline. All our old svn_string_* functions became svn_stringbuf_t
functions when we split the data type, and now there is a paucity
of svn_string_t functions.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:32 2006