[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: . ...

From: Joe Orton <jorton_at_btconnect.com>
Date: 2001-06-30 12:33:41 CEST

On Fri, Jun 29, 2001 at 11:14:23PM -0700, Greg Stein wrote:
> On Fri, Jun 29, 2001 at 12:12:57AM -0000, joe@tigris.org wrote:
...
> > AC_PROG_LIBTOOL
> > +
> > +dnl Configure neon --------------------------
> > +
> > +if test "$enable_subdir_config" = "yes"; then
> > + # neon (as of 0.15) defaults to not building shared libs, so
> > + # tell it to do whatever we're doing.
> > + if test "$enable_shared" = "yes"; then
> > + args="--enable-shared"
> > + else
> > + args="--disable-shared"
> > + fi
> > + APR_SUBDIR_CONFIG(neon, $args --with-expat="$abs_srcdir/expat-lite/libexpat.la")
>
> Note that APR_SUBDIR_CONFIG passes the top-level config args to the
> sub-config. So... this check is really about filling in a value (to override
> the default) for Neon where no cmdline option was specified.
>
> [ the comments kind of get into this, but don't tell the full story... ]

I wasn't very happy with the comment either, I'll fix it.

> > +
> > + AC_MSG_CHECKING([for any extra libraries neon needs])
> > + # this is not perfect since it will pick up extra -L flags too,
> > + # but that shouldn't do any real damage.
> > + NEON_LIBS=`$SHELL $abs_builddir/neon/neon-config --libs | sed -e "s/-lneon//g"`
> > + AC_MSG_RESULT([$NEON_LIBS])
> > +fi
>
> This probably should *not* be in the conditional. If the subdir config is
> skipped (i.e. it was done previously), then we still need to set NEON_LIBS.

Good point - thanks, I'll put it back where it was before. I noticed
that neon isn't adding the references to e.g. -lssl to libneon.so which
it should, so the "--enable-shared --with-ssl" build is broken. I'll fix
that in neon though.

joe

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:32 2006

This is an archived mail posted to the Subversion Dev mailing list.