[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_wc ...

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-06-09 11:33:02 CEST

On Fri, Jun 08, 2001 at 10:25:57PM -0500, Ben Collins-Sussman wrote:
> sussman@tigris.org writes:
> > User: sussman
> > Date: 01/06/08 20:04:36
> >
> > Modified: subversion/libsvn_wc adm_crawler.c get_editor.c
> > Log:
> > Finish fix for bug #337:
> > Updates now notice missing items and re-add them, and print '?' next
> > to unversioned items.
>
> I should point out that this new feature has a design flaw: the
> question marks are being printed on-the-fly with `printf' right smack
> in the middle of libsvn_wc.
>
> Obviously, this violates a design rule. No library should ever use
> printf; only the command-line client has that liberty.
>
> Hey CMike, wanna make it use your new top-level stream? It means
> adding a bunch of stream initialization stuff to the command-line
> client. But once it's done, any of our libraries will be able to
> print non-fatal warnings. (Woo!)

Having a library print to a stream abstraction is no better than doing a
printf().

Ask "what is the WC calling, which (in turn) prints the various items to
stdout?" Once you answer that, then figure out how the unversioned items can
do the same.

In no way should WC print "?" to a stream. That isn't going to work for GUI
clients. Are you considering that the GUI client should read and parse the
stream? :-)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:31 2006

This is an archived mail posted to the Subversion Dev mailing list.