Re: CVS update: MODIFIED: client ...

Greg Stein <gstein@lyra.org> writes:

> Actually, isn't our default *to* recurse? And we want an option to disable
> the recursion?

Yes and no. I mean, 'svn del dirname' recursively deletes, but 'svn
add dirname' does not recursively add. Likewise, 'svn undelete
dirname' does not automatically recurse. So for different operations,
different defaults apply. I could just have easily had a "don't
recurse" option and reversed the cases of everything.

> Whoops. Double negative in the comment gotcha. If it isn't an SVN dir, then
> you *do* add it to the target list.

Doh! Absolutely right.

> And the svn_string_create(SVN_WC_ADM_DIR_NAME) is bogus. Replace the
> svn_string_compare with:
>
> if (! strcmp(basename->data, SVN_WC_ADM_DIR_NAME) )
>
> Please get out of the mentality of always needing an svn_string_t. :-)

Grr...and I told myself I'd do better this time. :-(

Thanks, g.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:31 2006