[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Minor patch for Makefile.in

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-06-05 12:36:22 CEST

The chmod is a hack. The source files should have started with +x. We need
somebody to go into the CVS repository and do a +x on those script files
which don't have them already. At that point, then we can toss the chmod.

If the make check can't find the files, then we can generate TEST_PROGRAMS
to include the $(top_srcdir) when needed. Hmm. That won't work quite right
because we need to "cd". It should work if we test for existence, then use
abs_srcdir instead.

Cheers,
-g

On Tue, Jun 05, 2001 at 02:19:10AM -0700, Mo DeJong wrote:
> This patch should sort of get `make check` working
> for the $builddir != $srcdir case. There is still
> a problem after adding this patch because the
> configure script needs to create a subversion/client/tests
> directory in the build dir. You can hack that like so:
>
> % mkdir -p subversion/client/tests
>
> Now, I am the first to admit that this may not be
> the best patch ever, but you can't run a chmod
> on something in the srcdir since it can be on
> a read only filesystem. This patch just copies
> the .sh files from the test dir before running
> chmod on them.
>
> Mo
>
> Index: Makefile.in
> ===================================================================
> RCS file: /usr/local/tigris/data/helm/cvs/repository/subversion/Makefile.in,v
> retrieving revision 1.13
> diff -u -r1.13 Makefile.in
> --- Makefile.in 2001/06/04 22:06:39 1.13
> +++ Makefile.in 2001/06/05 09:14:49
> @@ -101,6 +101,10 @@
> echo > $$logfile ; \
> failed=no ; \
> list='$(TEST_PROGRAMS)'; for prog in $$list; do \
> + if test "$(abs_srcdir)" != "$(abs_builddir)" && \
> + test ! -f $$prog ; then \
> + cp $(abs_srcdir)/$$prog $$prog ; \
> + fi; \
> chmod a+x $$prog ; \
> progbase=`echo $$prog | sed 's?.*/??'` ; \
> progdir=`echo $$prog | sed 's?/[^/]*$$??'` ; \
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:31 2006

This is an archived mail posted to the Subversion Dev mailing list.