[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_subr ...

From: Karl Fogel <kfogel_at_collab.net>
Date: 2001-05-11 05:27:27 CEST

Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
> Speaking of target stuff, I have had some long ago changes to
> libsvn_subr/target.c to use apr_filepath_merge instead of my hacked up
> absolute_path function, but I am not sure whether apr_filepath_merge
> works on win32 yet. Should I commit it yet, or check with Bill<wrowe>
> first?

I wouldn't commit it right now, as any visible change in
svn_path_condense_targets()'s behavior could break the impending M2 (I
do mean any minute now). :-)

Maybe take this up after we've tagged M2...

Thanks for asking,
-Karl

> On Fri, May 11, 2001 at 01:36:43AM -0000, kfogel@tigris.org wrote:
> > User: kfogel
> > Date: 01/05/10 18:36:43
> >
> > Modified: subversion/tests/libsvn_subr target-test.c
> > Log:
> > (main): Put quotes around each target, so we can see empty strings
> > more easily.
> >
> > Revision Changes Path
> > 1.6 +4 -2 subversion/subversion/tests/libsvn_subr/target-test.c
> >
> > http://subversion.tigris.org/source/browse/subversion/subversion/tests/libsvn_subr/target-test.c.diff?r1=1.5&r2=1.6
> >
> > (In the diff below, changes in quantity of whitespace are not shown.)
> >
> > Index: target-test.c
> > ===================================================================
> > RCS file: /usr/local/tigris/data/helm/cvs/repository/subversion/subversion/tests/libsvn_subr/target-test.c,v
> > retrieving revision 1.5
> > retrieving revision 1.6
> > diff -u -b -r1.5 -r1.6
> > --- target-test.c 2001/05/11 01:32:23 1.5
> > +++ target-test.c 2001/05/11 01:36:42 1.6
> > @@ -43,7 +43,8 @@
> > }
> >
> > /* Call the function */
> > - err = svn_path_condense_targets(&common_path, &condensed_targets, targets, pool);
> > + err = svn_path_condense_targets(&common_path, &condensed_targets,
> > + targets, pool);
> > if (err != SVN_NO_ERROR)
> > svn_handle_error(err, stderr, 1);
> >
> > @@ -53,7 +54,8 @@
> > {
> > svn_string_t * target = ((svn_string_t**)condensed_targets->elts)[i];
> > if (target)
> > - printf("%s, ", ((svn_string_t **)condensed_targets->elts)[i]->data);
> > + printf("\"%s\", ",
> > + ((svn_string_t **)condensed_targets->elts)[i]->data);
> > else
> > printf("NULL, ");
> > }
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: cvs-unsubscribe@subversion.tigris.org
> > For additional commands, e-mail: cvs-help@subversion.tigris.org
> >
>
> --
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> Kevin Pilch-Bisson http://www.pilch-bisson.net
> "Historically speaking, the presences of wheels in Unix
> has never precluded their reinvention." - Larry Wall
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:30 2006

This is an archived mail posted to the Subversion Dev mailing list.