[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Purify is your friend.

From: Branko Čibej <brane_at_xbc.nu>
Date: 2001-05-10 20:23:13 CEST

Greg Stein wrote:

>On Thu, May 10, 2001 at 08:41:13AM +0200, brane@xbc.nu wrote:
>
>>...
>>The thing is, one would expect apr_pstrndup to behave like the standard strn*
>>functions, which also operate on "string"s, but guarantee not to touch anything
>>past the "n". (It doesn't /have/ to, of course.)
>>
>>Would it be O.K. if I changed the length check to use a memchr of '\0' instead
>>of strlen?
>>
>
>Seems like a fine solution!
>
Done. Works. No more ABRs in fs_test.

Now, could somebody please test this on a box that doesn't have memchr.
I've gone and provided a (tested!) memchr implementation in APR for just
this purpose, but I don't know of any such boxen.

-- 
Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:30 2006

This is an archived mail posted to the Subversion Dev mailing list.