Re: CVS update: subversion/subversion/tests/libsvn_repos repos-test.c

Greg Stein <gstein@lyra.org> writes:

> Is dir_delta obsolete? Does repos_update handle both dirs and files? If not,
> then can we make it so?

Yes and no. I mean, everything that *we* want to do with dir_delta
can be done with repos_update. But Jim expressed concern that being
able to describe the differences between any 2 arbitrary filesystem
directories might be useful to someone else using the FS interface.

Note that repos_update uses the same path, just under two different
roots. To fully combine these two functions into one, I think
repos_update would need to lose the PARENT_DIR and ENTRY arguments,
and gain SOURCE_PARENT_DIR, SOURCE_ENTRY, TARGET_PARENT_DIR, and
TARGET_ENTRY arguments. Which is fine, if that's what is necessary.
But it's not really a high priority for me right now, since I know
both users of the filesystem code, and they don't need this
functionality. :-)

> > Perhaps I should put all that in svn_repos.h ?
>
> Please. Your description is great, but that information certainly wasn't
> "extractable" in any easy form from the header. When somebody needs to build
> code, and needs to choose an API, then the guidance will be helpful.

Yessir.

> All righty. Let's say that close_edit will go into dir_delta unless Jim (or
> anybody else) can explain why it shouldn't.

Sounds good to me.
Received on Sat Oct 21 14:36:29 2006