[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_wc entries.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-04-18 01:04:26 CEST

On Tue, Apr 17, 2001 at 10:50:06PM -0000, sussman@tigris.org wrote:
>...
> The *real* problem is in svn_wc_get_entries(): this is a small
> symptom of a larger Iceberg-size change that needs to be made. In
> essence, get_entries needs to *stop* searching for information
> outside the immediate directory it's loading up, and all of its
> callers need to stop assuming that the entries hash returned will be
> perfectly complete.

Maybe return a structure that looks like:

  struct {
    entry_info this_dir;
    apr_hash_t *entries;
    apr_array_header_t *subdir_names;
  }

The above structure would scream "the hash only has file info!". You could
get the info for this_dir explicitly. Anything about subdirs needs to go
back for more via the subdir_names.

Note that the above structure *is* "perfectly complete", so the callers
don't need to handle a bazillion cases.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:28 2006

This is an archived mail posted to the Subversion Dev mailing list.