[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/tests/libsvn_wc commit-test.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-04-12 10:53:57 CEST

On Thu, Apr 12, 2001 at 08:02:39AM -0000, cmpilato@tigris.org wrote:
>...
> (svn_pool_destroy): New abstraction for apr_pool_destroy.

This seems a bit wacky. Just why do we have this? The function doesn't do
anything. And making people thing about a different function just leads them
to "what does this do?" And the answer is "nothing special"

What next? svn_pool_clear?

If svn_pool_destroy is not going to add any semantic value, then we should
not add the burden of its use.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:28 2006

This is an archived mail posted to the Subversion Dev mailing list.