[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [OT] commit methodology (was: Re: CVS update: ...)

From: Brian Behlendorf <brian_at_collab.net>
Date: 2001-03-29 19:15:46 CEST

On Thu, 29 Mar 2001, Greg Stein wrote:
> > Should anyone be allowed to check in code that breaks any tests? Personally I
> > think someone should only commit code when all the tests pass on his/her local
> > machine.
>
> This is a bit off-topic for this list, but what the heck. IMO, yes, people
> can/should be able to check in stuff according to whatever guidelines they
> care to impose upon themselves.

I generally agree, based on the assumption that there'll be a "stable"
branch at some point where the rules for committing will be a lot more
strict, and may include mandatory test runs for any commit, in preparation
for making a release. What would be nice would be to build a list of
functions and use cases that need tests written, so that those on the
fringe of development have something useful they can contribute - not only
is writing tests a good way for beginners to get more comfortable with the
code, having someone different than the original coder for a function
write the test for it is an important form of peer review.

        Brian
Received on Sat Oct 21 14:36:26 2006

This is an archived mail posted to the Subversion Dev mailing list.